[interp] Squash multiple call args moves into single opcode #52242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some vars cannot be used directly as an argument to another call. In this case, the var offset allocator generates new intermediary vars. For methods with a lot of parameters, we can end up with quite a lot of these stores.
As an example, for the following method:
```
public static void MethodPartial (int a, int b, object c, object d)
{
MethodFull (a, b, c, d, 12523);
}
```
Before:
```
IR_0000: ldc.i8 [72 <- nil], 12523
IR_0006: mov.4 [40 <- 0],
IR_0009: mov.4 [48 <- 8],
IR_000c: mov.8 [56 <- 16],
IR_000f: mov.8 [64 <- 24],
IR_0012: call [32 <- 40], 0
IR_0016: ret.void [nil <- nil],
```
After:
```
IR_0000: ldc.i8 [72 <- nil], 12523
IR_0006: mov.8.4 [nil <- nil], 40 <- 0, 48 <- 8, 56 <- 16, 64 <- 24
IR_000f: call [32 <- 40], 0
IR_0013: ret.void [nil <- nil]
```
ghost
added
the
|
Tagging subscribers to this area: @BrzVlad Issue DetailsPlus a few other small optimizations
|
vargaz
approved these changes
May 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus a few other small optimizations