-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[wasm] Improve exception handling measurements #52846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Improve exception handling measurements #52846
Conversation
Add conditional throw to the leaf methods to avoid optimizing out the exception handling code in `TryCatch` measurement. Add new `NoExceptionHandling` measurement to measure case when no exception handling is involved. Example measurement, chrome/amd64: | measurement | AOT | interp | |-:|-:|-:| | Exceptions, NoExceptionHandling | 0.0164us | 0.0558us | | Exceptions, TryCatch | 0.1400us | 0.0592us | | Exceptions, TryCatchThrow | 0.0064ms | 0.0028ms | | Exceptions, TryCatchFilter | 0.4415us | 0.0645us | | Exceptions, TryCatchFilterInline | 0.1263us | 0.0527us | | Json, non-ASCII text serialize | 1.4475ms | 8.6952ms | | Json, non-ASCII text deserialize | 6.5332ms | 12.2220ms | | Json, small serialize | 0.2020ms | 0.2362ms | | Json, small deserialize | 0.2293ms | 0.3614ms | | Json, large serialize | 53.3021ms | 68.0000ms | | Json, large deserialize | 61.5176ms | 100.0377ms |
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsAdd conditional throw to the leaf methods to avoid optimizing out the Add new Example measurements, chrome/amd64:
|
|
Failure is, looks like possibly the GC issue zoltan found. |
Add conditional throw to the leaf methods to avoid optimizing out the
exception handling code in
TryCatchmeasurement.Add new
NoExceptionHandlingmeasurement to measure case when noexception handling is involved.
Example measurements, chrome/amd64: