Expose the UseLocalTargetingRuntimePack property #53290
Conversation
and use it in the Microsoft.NETCore.Platforms package to avoid a dependency on the live built targeting and runtime pack / shared framework.
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue Detailsand use it in the Microsoft.NETCore.Platforms package to avoid a dependency on the live built targeting and runtime pack / shared framework.
|
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
I've performed a clean built of #53231 and confirmed that this PR is solving the problem I've hit. Big thanks @ViktorHofer !
|
The CI failures are caused by #53010 and some HTTPS certificate issues that I can see in other PRs as well (https://github.com/dotnet/runtime/pull/53294/checks?check_run_id=2677763699). Since this is blocking me, I am going to merge it now. Thanks! |
ericstj
left a comment
ericstj
left a comment
There was a problem hiding this comment.
Thanks for the fix. Only comment here is on the user experience. The project ends up setting two different things that say "I'm a tool running on tool runtime" NetCoreAppToolCurrent and UseLocalTargetingRuntimePack. Ideally it could be communicated in a common way, and done in the same way as other projects that have a similar requirement.
ghost
locked as resolved and limited conversation to collaborators
and use it in the Microsoft.NETCore.Platforms package to avoid a dependency on the live built targeting and runtime pack / shared framework.