[mono] Consolidate setret handling for diverging functions #53535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some functions never associate a mini IR source register with an LLVM value because they unconditionally throw. `System.Runtime.Intrinsics.X86.Aes:Decrypt` is an example of such a function; when compiled for arm64, it never returns a value and unconditionally throws a `PlatformNotSupportedException`. We already had support for handling this for some, but not all, return value passing conventions. Deduplicate this support and apply it uniformly to all return value passing conventions that expect a populated mini IR source register. Make `LLVMArgNone` specifically mean 'no return value'/`void` return type.
imhameed
requested review from
CoffeeFlux,
EgorBo,
SamMonoRT,
lambdageek and
vargaz
as code owners
lambdageek
approved these changes
Jun 2, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some functions never associate the mini IR source registers used with their
setretinstructions with LLVM values because they unconditionally throw.System.Runtime.Intrinsics.X86.Aes:Decryptis an example of such a function;when compiled for arm64, it never returns a value and unconditionally throws a
PlatformNotSupportedException.We already had support for handling this for some, but not all, return value
passing conventions. Deduplicate this support and apply it uniformly to all
return value passing conventions that expect a populated mini IR source
register.
Make
LLVMArgNonespecifically mean "no return value"/"voidreturntype".
Split from #53132.
Partially fixes FullAOT compilation of System.Private.CoreLib.dll on arm64.