HTTP/3: Remove ASP.NET Core specific code from QPackEncoder #54378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThis PR removes the non-static members from shared QPackEncoder. These methods are only used by ASP.NET Core. It is easier to have them in a non-shared file in the ASP.NET Core repo so changes don't need to be synced. This change makes QPackEncoder consistent with HPackEncoder which is also static and the ASP.NET Core specific methods are in a different file in the ASP.NET Core repo.
|
Tratcher
approved these changes
Jun 17, 2021
Member
Author
|
runtime folks: Is this ok to merge? MacOS ARM build is timing out. Seems unrelated but I want to double check. |
karelz
requested review from
CarnaViire,
ManickaP,
geoffkizer,
scalablecory and
wfurt
Member
|
Thanks for checking. This leg has been having problems all day. It's not you. |
stephentoub
approved these changes
Jun 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the non-static members from shared QPackEncoder. These methods are only used by ASP.NET Core. It is easier to have them in a non-shared file in the ASP.NET Core repo so changes don't need to be synced.
This change makes QPackEncoder consistent with HPackEncoder which is also static and the ASP.NET Core specific methods are in a different file in the ASP.NET Core repo.