Skip to content

Access modifier cleanup in Task #55842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Access modifier cleanup in Task #55842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6746591
Update Task.cs
WizardBrony Jul 16, 2021
8314567
Update TaskFactory.cs
WizardBrony Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/Task.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,7 @@ internal bool IsWaitNotificationEnabledOrNotRanToCompletion
/// harmful). Derived implementations may choose to only conditionally call down to this base
/// implementation.
/// </summary>
internal virtual bool ShouldNotifyDebuggerOfWaitCompletion // ideally would be familyAndAssembly, but that can't be done in C#
private protected virtual bool ShouldNotifyDebuggerOfWaitCompletion
{
get
{
Expand Down Expand Up @@ -5889,7 +5889,7 @@ public void Invoke(Task completedTask)
/// Returns whether we should notify the debugger of a wait completion. This returns
/// true iff at least one constituent task has its bit set.
/// </summary>
internal override bool ShouldNotifyDebuggerOfWaitCompletion =>
private protected override bool ShouldNotifyDebuggerOfWaitCompletion =>
base.ShouldNotifyDebuggerOfWaitCompletion &&
AnyTaskRequiresNotifyDebuggerOfWaitCompletion(m_tasks);
}
Expand Down Expand Up @@ -6128,7 +6128,7 @@ public void Invoke(Task ignored)
/// Returns whether we should notify the debugger of a wait completion. This returns true
/// iff at least one constituent task has its bit set.
/// </summary>
internal override bool ShouldNotifyDebuggerOfWaitCompletion =>
private protected override bool ShouldNotifyDebuggerOfWaitCompletion =>
base.ShouldNotifyDebuggerOfWaitCompletion &&
AnyTaskRequiresNotifyDebuggerOfWaitCompletion(m_tasks);
}
Expand Down
4 changes: 2 additions & 2 deletions src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/TaskFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1587,7 +1587,7 @@ public void Invoke(Task completingTask)
/// Returns whether we should notify the debugger of a wait completion. This returns
/// true iff at least one constituent task has its bit set.
/// </summary>
internal override bool ShouldNotifyDebuggerOfWaitCompletion =>
private protected override bool ShouldNotifyDebuggerOfWaitCompletion =>
base.ShouldNotifyDebuggerOfWaitCompletion &&
AnyTaskRequiresNotifyDebuggerOfWaitCompletion(_tasks);
}
Expand Down Expand Up @@ -1657,7 +1657,7 @@ public void Invoke(Task completingTask)
/// Returns whether we should notify the debugger of a wait completion. This returns
/// true iff at least one constituent task has its bit set.
/// </summary>
internal override bool ShouldNotifyDebuggerOfWaitCompletion =>
private protected override bool ShouldNotifyDebuggerOfWaitCompletion =>
base.ShouldNotifyDebuggerOfWaitCompletion &&
AnyTaskRequiresNotifyDebuggerOfWaitCompletion(_tasks);
}
Expand Down