Skip to content

Cleanup disabled DNS test conditions #56381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Cleanup disabled DNS test conditions #56381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostEntryTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public async Task Dns_GetHostEntryAsync_IPAddress_Ok()
// [ActiveIssue("https://github.com/dotnet/runtime/issues/27622")]
PlatformDetection.IsNotArmNorArm64Process &&
// [ActiveIssue("https://github.com/dotnet/runtime/issues/1488", TestPlatforms.OSX)]
PlatformDetection.IsNotOSX &&
!PlatformDetection.IsOSX &&
// [ActiveIssue("https://github.com/dotnet/runtime/issues/51377", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
!PlatformDetection.IsiOS && !PlatformDetection.IstvOS && !PlatformDetection.IsMacCatalyst &&
// [ActiveIssue("https://github.com/dotnet/runtime/issues/55271")]
Expand All @@ -39,12 +39,6 @@ public async Task Dns_GetHostEntryAsync_IPAddress_Ok()
[InlineData(TestSettings.LocalHost)]
public async Task Dns_GetHostEntry_HostString_Ok(string hostName)
{
if (PlatformDetection.IsSLES)
{
// See https://github.com/dotnet/runtime/issues/55271
throw new SkipTestException("SLES Tests environment is not configured for this test to work.");
}

try
{
await TestGetHostEntryAsync(() => Task.FromResult(Dns.GetHostEntry(hostName)));
Expand Down Expand Up @@ -93,12 +87,6 @@ public async Task Dns_GetHostEntry_HostString_Ok(string hostName)
[InlineData(TestSettings.LocalHost)]
public async Task Dns_GetHostEntryAsync_HostString_Ok(string hostName)
{
if (PlatformDetection.IsSLES)
{
// See https://github.com/dotnet/runtime/issues/55271
throw new SkipTestException("SLES Tests environment is not configured for this test to work.");
}

await TestGetHostEntryAsync(() => Dns.GetHostEntryAsync(hostName));
}

Expand Down