Skip to content

Conversation

@roji
Copy link
Member

@roji roji commented Jul 29, 2021

Allow implementations of DbBatchCommandCollection to hide the indexer with a narrower-typed version for their own implementation of DbBatchCommand, as elsewhere in ADO.NET.

This follows the existing pattern in DbParameterCollection.

Fixup for #54467, part of #28633

@bgrainger @bricelam would appreciate a quick review of this (it's small), to make sure this goes into rc1.

/cc @Wraith2 @FransBouma @bgribaudo @yyjdelete @ajcvickers

Allow implementations of DbBatchCommandCollection to hide the indexer
with a narrower-typed version for their own implementation of
DbBatchCommand, as elsewhere in ADO.NET.

Fixup for #54467, part of #28633
@roji roji requested a review from bricelam July 29, 2021 09:10
@ghost
Copy link

ghost commented Jul 29, 2021

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jul 29, 2021

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

Allow implementations of DbBatchCommandCollection to hide the indexer with a narrower-typed version for their own implementation of DbBatchCommand, as elsewhere in ADO.NET.

This follows the existing pattern in DbParameterCollection.

Fixup for #54467, part of #28633

@bgrainger @bricelam would appreciate a quick review of this (it's small), to make sure this goes into rc1.

/cc @Wraith2 @FransBouma @bgribaudo @yyjdelete @ajcvickers

Author: roji
Assignees: -
Labels:

area-System.Data, new-api-needs-documentation

Milestone: -

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants