[QUIC] Fix QUIC stream handle leak #56550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsDiscovered that while investigating stress tests failures. We had this code in the end of Fixes #56151
|
geoffkizer
approved these changes
Jul 29, 2021
Contributor
|
This is one of the causes of the leak I've seen in HTTP3 unit tests. Good to get this fixed. |
Member
Author
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Just for the record, stress failures are known issue #56310. I hoped this could mitigate it at least a little bit, but it did not. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered that while investigating stress tests failures. We had this code in the end of
HandleEventShutdownComplete, but if we received a flag that connection was closed in that event, we branched early toHandleEventConnectionClosewhich lacked this logic.Fixes #56151