Skip to content

Conversation

@antonfirsov
Copy link
Contributor

@antonfirsov antonfirsov commented Aug 6, 2021

I'm having trouble reproducing #56159 with logging enabled. Still waiting if this change will actually help, but I believe bringing the characteristics of logging test execution closer to non-logging one is worth a quick review.

This PR is eliminating autoflush, blocking calls and Task allocations in LogHttpEventListener, which can go expensive, when logging several thousands of lines per sec.

Also moving all client log files to subfolder ./clientlog, since it seems easier to manage but I won't insist on that.

/cc @ManickaP

@ghost ghost added the area-System.Net.Http label Aug 6, 2021
@ghost
Copy link

ghost commented Aug 6, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

I'm having trouble reproducing #56159 with logging enabled. Still waiting if this change will actually help, but I believe bringing the characteristics of logging test execution closer to non-logging one is worth a quick review.

This PR is eliminating blocking calls and Task allocations in LogHttpEventListener, which can go expensive, when logging several thousands of lines per sec.

Also moving all client log files to subfolder ./clientlog, since it seems easier to manage but I won't insist on that.

/cc @ManickaP

Author: antonfirsov
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@antonfirsov antonfirsov requested a review from a team August 6, 2021 14:34
Copy link
Contributor

@alnikola alnikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonfirsov
Copy link
Contributor Author

I will go ahead and merge this, since I believe this improves the usability of StressClient logging. @ManickaP if you have any concerns let me know!

@antonfirsov antonfirsov merged commit 8327778 into dotnet:main Aug 13, 2021
@karelz karelz added this to the 6.0.0 milestone Aug 17, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants