-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Enforce scatter/gather file I/O Windows API requirements et. al. #57424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adamsitnik
merged 13 commits into
dotnet:main
from
teo-tsirpanis:windows-vectored-io-refactor
Aug 31, 2021
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d32cf8b
Move checking and pinning Windows vectored I/O buffers to a dedicated…
teo-tsirpanis 2d8e82f
Refactor the scatter/gather APIs to use the common checking method.
teo-tsirpanis 26e5350
Shorten the name of the buffer-checking method.
teo-tsirpanis d7b82ff
Directly get the pinned array's address instead of calling GCHandle.A…
teo-tsirpanis a160f1d
Refactor the error handling logic in TryPrepareScatterGatherBuffers.
teo-tsirpanis 656adf6
Allocate the segment array from native memory and at TryPrepareScatte…
teo-tsirpanis e1b94a9
Cache the page size on a static readonly field and add a couple of TO…
teo-tsirpanis 92924d8
Make the memory handlers readonly structs.
teo-tsirpanis b1d60b6
Add a test.
teo-tsirpanis 749b6c7
Reorder some methods with PR feedback taken into consideration.
teo-tsirpanis 4b940a4
Merge branch 'main' into windows-vectored-io-refactor
teo-tsirpanis 5ed633d
Stop special-casing scatter/gather operations with zero or one buffer.
teo-tsirpanis 7e75cc7
Factor the cleaning-up of the segment buffers into a separate method.
teo-tsirpanis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.