Skip to content

Conversation

@eerhardt
Copy link
Member

#56271 broke a scenario in ASP.NET. Reverting the change for now.

cc @NinoFloris

@ghost
Copy link

ghost commented Aug 17, 2021

Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

#56271 broke a scenario in ASP.NET. Reverting the change for now.

cc @NinoFloris

Author: eerhardt
Assignees: -
Labels:

area-Extensions-Options

Milestone: -

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the revert was done programmatically so didn't review it in depth (which is a funny thing to say for basically a one-liner 😄). Thanks.

@eerhardt
Copy link
Member Author

I assume the revert was done programmatically so didn't review it in depth

yes, the first commit was done with git revert 8f5f9d049a6a98b138f88fa1d9d6a96c40c03aa7. The 2nd commit was a hand-written test for the failing ASP.NET scenario.

@eerhardt
Copy link
Member Author

Merging to make sure this gets into 6.0.

@eerhardt eerhardt merged commit f21b2e3 into dotnet:main Aug 17, 2021
@eerhardt eerhardt deleted the Revert56271 branch August 17, 2021 18:13
@eerhardt
Copy link
Member Author

FYI - @wtgodbe - when aspnetcore gets this new build, you will need to revert the test change you made in the last runtime update.

@wtgodbe
Copy link
Member

wtgodbe commented Aug 17, 2021

CC @halter73 this'll come in w/ tomorrow's runtime update(s), we'll need to fix the test in all 3 branches (unless we can get it into main before 5, which might be cutting it close w/ the runtime build time + our CI time)

@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants