Skip to content

Conversation

@gbalykov
Copy link
Member

@gbalykov gbalykov commented Sep 2, 2021

Originally there was only one eventpipe test, and eventpipe_readevents was added in #37002.
Both should be skipped for the same reason.

cc @alpencolt

Originally there was only one eventpipe test, and eventpipe_readevents was added in dotnet#37002.
Both should be skipped for the same reason.
@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-Tracing-coreclr labels Sep 2, 2021
@tommcdon
Copy link
Member

@josalem

@josalem
Copy link
Contributor

josalem commented Sep 27, 2021

@davmason is there any reason we would need to disable eventpipe profiler tests on arm32 but not regular eventpipe tests? I would expect TraceEvent alignment issues to affect all variants of EventPipe tests.

@davmason
Copy link
Contributor

The profiler tests construct EventPipe data blobs manually, so it's possible the tests themselves are hitting alignment issues not seen in TraceEvent. I don't know if that's what happening, but it is a potential difference.

@davmason
Copy link
Contributor

@gbalykov is this still necessary?

@gbalykov
Copy link
Member Author

I think so, I do not see any changes in main branch related to this

@tommcdon
Copy link
Member

Thanks for the contribution @gbalykov! I'm merging this PR. According to runfo we have a couple of test failures in the last week on arm, and so we should disable the failing test while we investigate the failures.

https://runfo.azurewebsites.net/search/tests/?q=started%3A%7E7+definition%3Aruntime+name%3A%22eventpipe_readevents%22+jobName%3A%22arm+%22

Test Run Build Kind Helix Console Helix Run Client Helix Core Dump Helix Test Results Message
CoreCLR Linux arm Checked no_tiered_compilation @ (Ubuntu.1804.Arm32.Open)[email protected]/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm32v7-bfcd90a-20200121150440 1476826 Pull Request Console Run Client Core Dump   Assert failure(PID 76 [0x0000004c], Thread: 76 [0x004c]): Verify_TypeLayout 'AssertInterpolatedStringHandler' failed to verify type layout File: /__w/1/s/src/coreclr/vm/jitinterface.cpp Line: 13674 Image: /root/helix/work/correlation/corerun /root/helix/work/workitem/e/profiler/eventpipe/eventpipe_readevents/eventpipe_readevents.sh: line 393: 76 Aborted (core dumped) $LAUNCHER $ExePath "${CLRTestExecutionArguments[@]}" Return code: 1 Raw output file: /root/helix/work/workitem/uploads/Reports/profiler.eventpipe/eventpipe_readevents/eventpipe_readevents.output.txt Raw output: BEGIN EXECUTION /root/helix/work/correlation/corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false eventpipe_readevents.dll '' Type AssertInterpolatedStringHandler: GC refmap content doesn't match Gathering state for process 76 corerun Crashing thread 0000004c signal 00000006 Writing minidump with heap to file /home/helixbot/dotnetbuild/dumps/coredump.76.dmp Written 53530624 bytes (13069 pages) to core file Dump successfully written Expected: 100 Actual: 134 END EXECUTION - FAILED Test Harness Exitcode is : 1 To run the test: > set CORE_ROOT=/root/helix/work/correlation > /root/helix/work/workitem/e/profiler/eventpipe/eventpipe_readevents/eventpipe_readevents.sh Expected: True Actual: False
CoreCLR Linux arm Checked @ (Ubuntu.1804.Arm32.Open)[email protected]/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm32v7-bfcd90a-20200121150440 1476826 Pull Request Console Run Client Core Dump   Assert failure(PID 78 [0x0000004e], Thread: 78 [0x004e]): Verify_TypeLayout 'AssertInterpolatedStringHandler' failed to verify type layout File: /__w/1/s/src/coreclr/vm/jitinterface.cpp Line: 13674 Image: /root/helix/work/correlation/corerun /root/helix/work/workitem/e/profiler/eventpipe/eventpipe_readevents/eventpipe_readevents.sh: line 393: 78 Aborted (core dumped) $LAUNCHER $ExePath "${CLRTestExecutionArguments[@]}" Return code: 1 Raw output file: /root/helix/work/workitem/uploads/Reports/profiler.eventpipe/eventpipe_readevents/eventpipe_readevents.output.txt Raw output: BEGIN EXECUTION /root/helix/work/correlation/corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false eventpipe_readevents.dll '' Type AssertInterpolatedStringHandler: GC refmap content doesn't match Gathering state for process 78 corerun Crashing thread 0000004e signal 00000006 Writing minidump with heap to file /home/helixbot/dotnetbuild/dumps/coredump.78.dmp Written 61878272 bytes (15107 pages) to core file Dump successfully written Expected: 100 Actual: 134 END EXECUTION - FAILED Test Harness Exitcode is : 1 To run the test: > set CORE_ROOT=/root/helix/work/correlation > /root/helix/work/workitem/e/profiler/eventpipe/eventpipe_readevents/eventpipe_readevents.sh Expected: True Actual: False

@tommcdon tommcdon self-requested a review November 22, 2021 17:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Tracing-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants