[release/6.0] [mini] Use alloca for runtime_invoke retval buffer #59006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the common case we use the return buffer just to hold a pointer to the return value
github-actions
bot
requested review from
SamMonoRT,
imhameed,
lambdageek and
vargaz
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
marek-safar
approved these changes
Sep 13, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58978 to release/6.0
/cc @lambdageek
Customer Impact
Fixes #58957
User programs on ios devices that use
System.Text.Jsonto serialize large structs may crash during CC.Corrects a GC hole introduced by #58364 which was a fix for #58190.
Testing
CI and manual testing.
Risk
Low. The logic is the same, except instead of using dynamic heap allocation we use
allocato heap allocate the return vlaue buffer.