Remove ILStrip temporarily to retain ActiveIssue attributes in release mobile device configuration #59762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e mobile device configuration
ghost
added
the
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsContributes to #59488 This PR looks to temporarily remove the ILStrip task from mobile targets. In doing so, ActiveIssue attributes will be properly skipped at the cost of some size that would be saved in stripping, though it is not technically needed. Until the right fix is found, ensuring ActiveIssue'd tests are skipped will improve the pass rate of the iOS/tvOS arm64 runtime-staging lanes.
|
steveisok
approved these changes
Sep 29, 2021
safern
approved these changes
Sep 29, 2021
added 2 commits
September 29, 2021 16:30
…ve_ilstrip_for_activeissue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #59488
This PR looks to temporarily remove the ILStrip task from mobile targets. In doing so, ActiveIssue attributes will be properly skipped at the cost of some size that would be saved in stripping, though it is not technically needed. Until the right fix is found, ensuring ActiveIssue'd tests are skipped will improve the pass rate of the iOS/tvOS arm64 runtime-staging lanes.