Skip to content

Conversation

@github-actions
Copy link
Contributor

This PR was automatically generated to sync shared code changes from aspnetcore. Fixes dotnet/aspnetcore#18943

@github-actions github-actions bot requested a review from a team November 26, 2021 02:25
@ghost
Copy link

ghost commented Nov 26, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR was automatically generated to sync shared code changes from aspnetcore. Fixes dotnet/aspnetcore#18943

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@JamesNK
Copy link
Member

JamesNK commented Nov 26, 2021

Synced changes from fixing dotnet/aspnetcore#38604

This code is related to writing :status which SocketsHttpHandler won't use. There might be some reaction required if there is test code that writes a status.

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
No reaction is needed for tests AFAIK, because tests (for some unknown reason) use separate simplified encoders for both HPACK and QPACK -- and they don't touch files from the shared folder -- maybe that should be changed in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The runtime<->aspnetcore shared src is out of sync

5 participants