Use interpolated strings in place of StringBuilder.AppendFormat where possible.
#62160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
stephentoub
reviewed
Nov 30, 2021
src/libraries/Microsoft.Extensions.DependencyInjection/src/CallSiteJsonFormatter.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 30, 2021
...ies/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/MetricsEventSource.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 30, 2021
...s/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/SignedXmlDebugLog.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 30, 2021
src/libraries/System.Speech/src/Internal/Synthesis/TextFragmentEngine.cs
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts all calls to
StringBuilder.AppendFormatin non-test code to instead useStringBuilder.Appendwith interpolated strings, taking advantage of the .NET 6 interpolated string handlers, that allocate zero intermediate objects, writing the characters directly to theStringBuilderin our case.Call sites where the format strings were obtained from resources could not be optimized and were not changed.
Earlier frameworks might see a slightly decreased performance but the changed code does not seem to be performance-critical.