[mono][wasm] Fix the passing/returning of small vtypes. #62299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vargaz
requested review from
EgorBo,
SamMonoRT,
imhameed and
lambdageek
as code owners
According to the ABI, they need to be returned by value.
vargaz
force-pushed
the
wasm-aot-vtype2
branch
from
82d3528 to
6fb6d49
Compare
lateralusX
approved these changes
Dec 3, 2021
Member
lateralusX
left a comment
lateralusX
left a comment
There was a problem hiding this comment.
The mini-llvm.h|c changes looks good to me, have been extending it on win64 with similar solution and that pass all mini regression tests using full AOT LLVM.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the ABI, they need to be returned by value.