Skip to content

[wasm] Re-enable windows wasm AOT tests #62352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 5, 2021
Merged

[wasm] Re-enable windows wasm AOT tests #62352

merged 6 commits into from
Dec 5, 2021

Conversation

@radical
Copy link
Member

@radical radical commented Dec 3, 2021

They had been disabled earlier because of #61721

@radical
[wasm] Re-enable windows wasm AOT tests
098fc9e 
They had been disabled earlier because of dotnet#61721
@radical radical added arch-wasm WebAssembly architecture area-Codegen-AOT-mono labels Dec 3, 2021
@ghost
Copy link

ghost commented Dec 3, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

They had been disabled earlier because of #61721

Author: radical
Assignees: -
Labels:

arch-wasm, area-Codegen-AOT-mono
Milestone: -

@radical
Copy link
Member Author

radical commented Dec 3, 2021

cc @radekdoulik @vargaz

@radical
Copy link
Member Author

radical commented Dec 3, 2021

/azp run runtime-manual

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 3, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Dec 3, 2021

/azp run runtime-manual

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 3, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Dec 3, 2021
lewing
lewing approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge when green

This was referenced Dec 3, 2021
Closed
Closed
@radical
Copy link
Member Author

radical commented Dec 4, 2021

/azp run runtime-manual

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 4, 2021

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Dec 4, 2021
Merged
Closed
@radical
Copy link
Member Author

radical commented Dec 4, 2021

/azp run runtime-manual

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 4, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Dec 4, 2021
@radical
Copy link
Member Author

radical commented Dec 4, 2021

/azp run runtime-manual

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 4, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical merged commit fedf64f into dotnet:main Dec 5, 2021
@radical radical deleted the enable-windows-aot branch December 5, 2021 01:15
@runfoapp runfoapp bot mentioned this pull request Dec 6, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewing lewing lewing approved these changes

@vargaz vargaz Awaiting requested review from vargaz

@radekdoulik radekdoulik Awaiting requested review from radekdoulik

Assignees

No one assigned

Labels

arch-wasm WebAssembly architecture area-Codegen-AOT-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radical @lewing