Skip to content

don't run CanZipNamedPipe test on iOS/tvOS #62477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2021
+2 −2
Merged

don't run CanZipNamedPipe test on iOS/tvOS #62477

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
453d659
don't run the test on iOS/tvOS
adamsitnik Dec 7, 2021
c49fffd
disable the buffering as originally intended https://github.com/dotne…
adamsitnik Dec 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/System.IO.Compression.ZipFile/tests/ZipFile.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ public void UnixExtractFilePermissionsCompat(string zipName, string expectedPerm
}

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser)]
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.tvOS & ~TestPlatforms.iOS)]
public async Task CanZipNamedPipe()
{
string destPath = Path.Combine(TestDirectory, "dest.zip");
Expand All @@ -155,7 +155,7 @@ public async Task CanZipNamedPipe()
await Task.WhenAll(
Task.Run(() =>
{
using FileStream fs = new (fifoPath, FileMode.Open, FileAccess.Write, FileShare.Read);
using FileStream fs = new (fifoPath, FileMode.Open, FileAccess.Write, FileShare.Read, bufferSize: 0);
Copy link
Member

@stephentoub stephentoub Dec 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated to iOS and instead for my comments on the previous PR? Just confirming.

Copy link
Member Author

@adamsitnik adamsitnik Dec 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated to iOS and instead for my comments on the previous PR? Just confirming.

Yes, exactly. I did not want to send a new PR for this small change so I've used the test failure as an opportunity to address the old feedback as well.

foreach (byte content in contentBytes)
{
fs.WriteByte(content);
Expand Down