Skip to content

[wasm] Decrease the startup ceremony #62587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 10, 2021
Merged

[wasm] Decrease the startup ceremony #62587

merged 3 commits into from
Dec 10, 2021

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Dec 9, 2021

Decrease the startup ceremony

  • default config when empty DotnetModuleConfig
  • default onAbort, including error propagation to ready promise
  • new API MONO.mono_run_main_and_exit and MONO.mono_run_main
  • console-v8-cjs sample

@ghost
Copy link

ghost commented Dec 9, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

maraf
maraf approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavelsavara pavelsavara merged commit 25c2073 into dotnet:main Dec 10, 2021
@pavelsavara pavelsavara mentioned this pull request Dec 10, 2021
Merged
@pavelsavara pavelsavara deleted the wasm_run_api branch January 4, 2022 13:06
@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@maraf maraf maraf approved these changes

@kg kg Awaiting requested review from kg

@radekdoulik radekdoulik Awaiting requested review from radekdoulik

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pavelsavara @maraf