Add custom marshaller tests for delegates #62691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests added to better test ICustomMarshaller support in NativeAOT as per discussed with @jkotas
ghost
added
community-contribution
jkoritzinsky
approved these changes
Dec 12, 2021
Member
jkoritzinsky
left a comment
jkoritzinsky
left a comment
There was a problem hiding this comment.
Thanks for improving our test coverage!
Too much copy-pasta is bad for your health.
Contributor
Author
|
@jkoritzinsky anything else needed for this PR? |
Member
|
Can you remove the places where you set CallingConvention? In native code, STDMETHODCALLTYPE is stdcall on Windows and cdecl on non-Windows, aka the DllImport default. |
jkoritzinsky
requested changes
Dec 14, 2021
| using TestDelegate = LPCSTR(STDMETHODCALLTYPE*)(int); | ||
| using TestDelegateRef = LPCSTR(STDMETHODCALLTYPE*)(int*); | ||
|
|
||
| extern "C" int DLL_EXPORT STDMETHODCALLTYPE NativeParseInt(LPCSTR str) |
Member
There was a problem hiding this comment.
Please keep the STDMETHODCALLTYPEs on the native methods without adding a CallingConvention= setter in managed.
Contributor
Author
There was a problem hiding this comment.
Yeah. I reread again and understand that you want like that. Done.
ghost
added
needs-author-action
jkoritzinsky
approved these changes
Dec 14, 2021
Contributor
Author
|
@jkoritzinsky can you merge now? I would like to continue work on ICustomMarshaller for NativeAOT |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests added to better test ICustomMarshaller support in NativeAOT as per discussed with @jkotas