Skip to content

Conversation

@SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Dec 12, 2021

CLS_VAR stores have the same truncating semantics as IND stores (they are, in fact, the same in the backend), we can take advantage of that and remove some casts.

This is another change that will help make the deletion of CLS_VAR zero-diff.

Diffs.

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Dec 12, 2021
@ghost
Copy link

ghost commented Dec 12, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

CLS_VAR stores have the same truncating semantics as IND stores (they are, in fact, the same in the backend), we can take advantage of that and remove some casts.

This is another change that will help make the deletion of CLS_VAR zero-diff.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

@SingleAccretion SingleAccretion changed the title Remove small casts on the RHS of ASG(CLS_VAR) Remove small casts on the RHS of ASG(CLS_VAR) Dec 12, 2021
@SingleAccretion SingleAccretion marked this pull request as ready for review December 12, 2021 22:16
@SingleAccretion
Copy link
Contributor Author

@dotnet/jit-contrib

Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jakobbotsch jakobbotsch merged commit eca7c43 into dotnet:main Dec 19, 2021
@SingleAccretion SingleAccretion deleted the Remove-Small-Casts-For-ClsVar-Stores branch December 20, 2021 09:22
@ghost ghost locked as resolved and limited conversation to collaborators Jan 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants