Skip to content

Disable some suspicious tests which might lead to OOM crashes on Android emulators and arm64 devices #62767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Dec 17, 2021
Merged

Disable some suspicious tests which might lead to OOM crashes on Android emulators and arm64 devices #62767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
f2ed95b
Disable some suspicious test classes which might lead to OOM crashes …
MaximLipnin Dec 14, 2021
36632c1
Disable more tests
MaximLipnin Dec 14, 2021
4b1bd1b
Run the crypto tests by the default
MaximLipnin Dec 14, 2021
94e9ffa
Disable individual tests
MaximLipnin Dec 14, 2021
84e391b
Disable more tests
MaximLipnin Dec 14, 2021
1a1afdc
Disable more tests
MaximLipnin Dec 14, 2021
0dbe2e7
Merge branch 'main' into disable_crypto_tests_on_android
MaximLipnin Dec 15, 2021
be86e39
Clean up
MaximLipnin Dec 15, 2021
fb10abc
Enable RSAKeyFileTests.BadPbeParameters()
MaximLipnin Dec 15, 2021
f0d6208
Enable RSAKeyFileTests.NoPrivKeyFromPublicOnly()
MaximLipnin Dec 15, 2021
5b841f4
Enable RSAKeyFileTests.NoFuzzyEncryptedPkcs8()
MaximLipnin Dec 15, 2021
1be17b5
Enable RSAKeyFileTests.NoFuzzyPkcs8()
MaximLipnin Dec 15, 2021
f1695f9
Enable RSAKeyFileTests.ReadWriteBigExponentPrivatePkcs1()
MaximLipnin Dec 15, 2021
2755d0b
Enable RSAKeyFileTests.ReadWriteDiminishedDPPrivatePkcs1()
MaximLipnin Dec 15, 2021
bf2f1c2
Disable ReadWriteDiminishedDPPrivatePkcs1() due to crash; enable Read…
MaximLipnin Dec 15, 2021
efa4490
Enable RSAKeyFileTests.ReadWriteSubjectPublicKeyInfo_DiminishedDPKey()
MaximLipnin Dec 15, 2021
a9c539a
Enable RSAKeyFileTests.ReadWriteRsa16384SubjectPublicKeyInfo()
MaximLipnin Dec 15, 2021
d15576c
Enable RSAKeyFileTests.ReadEncryptedDiminishedDP
MaximLipnin Dec 16, 2021
32fd34b
Enable RSAKeyFileTests.ReadEncryptedRsa1032()
MaximLipnin Dec 16, 2021
407bb81
Enable RSAKeyFileTests.NoFuzzyRSAPublicKey()
MaximLipnin Dec 16, 2021
320a324
Enable RSAKeyFileTests.ReadEncryptedDiminishedDP_EmptyPassword()
MaximLipnin Dec 16, 2021
e621b63
Add GH issue
MaximLipnin Dec 16, 2021
4aeaa7c
Merge branch 'main' into disable_crypto_tests_on_android
MaximLipnin Dec 17, 2021
7215b0b
Remove temp smoke test section
MaximLipnin Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,6 +565,7 @@ public static void DecryptPkcs12WithBytes()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)]
public static void DecryptPkcs12PbeTooManyIterations()
{
// pbeWithSHAAnd3-KeyTripleDES-CBC with 600,001 iterations
Expand All @@ -585,6 +586,7 @@ public static void DecryptPkcs12PbeTooManyIterations()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)]
public static void ReadWriteDsa1024EncryptedPkcs8_Pbes2HighIterations()
{
// pkcs5PBES2 hmacWithSHA256 aes128-CBC with 600,001 iterations
Expand Down
2 changes: 2 additions & 0 deletions ...s/Common/tests/System/Security/Cryptography/AlgorithmImplementations/EC/ECKeyFileTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,6 +959,7 @@ public void DecryptPkcs12WithBytes()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)]
public void DecryptPkcs12PbeTooManyIterations()
{
// pbeWithSHAAnd3-KeyTripleDES-CBC with 600,001 iterations
Expand All @@ -976,6 +977,7 @@ public void DecryptPkcs12PbeTooManyIterations()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)]
public void ReadWriteEc256EncryptedPkcs8_Pbes2HighIterations()
{
// pkcs5PBES2 hmacWithSHA256 aes128-CBC with 600,001 iterations
Expand Down
1 change: 1 addition & 0 deletions ...ests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaTests.netcoreapp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
namespace System.Security.Cryptography.EcDsa.Tests
{
[SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)]
public sealed class ECDsaTests_Span : ECDsaTests
{
protected override bool VerifyData(ECDsa ecdsa, byte[] data, int offset, int count, byte[] signature, HashAlgorithmName hashAlgorithm) =>
Expand Down
4 changes: 4 additions & 0 deletions ...Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ public static void ReadWriteBigExponentPrivatePkcs1()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)]
public static void ReadWriteDiminishedDPPrivatePkcs1()
{
ReadWriteBase64PrivatePkcs1(
Expand Down Expand Up @@ -789,6 +790,7 @@ public static void ReadPbes2Rc2EncryptedDiminishedDP_PasswordBytes()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)]
public static void ReadEncryptedDiminishedDP_EmptyPassword()
{
// [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Suppression approved. Unit test key.")]
Expand Down Expand Up @@ -1254,6 +1256,7 @@ public static void DecryptPkcs12WithBytes()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)]
public static void DecryptPkcs12PbeTooManyIterations()
{
// pbeWithSHAAnd3-KeyTripleDES-CBC with 600,001 iterations
Expand Down Expand Up @@ -1290,6 +1293,7 @@ public static void DecryptPkcs12PbeTooManyIterations()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)]
public static void ReadWriteRsa2048EncryptedPkcs8_Pbes2HighIterations()
{
// pkcs5PBES2 hmacWithSHA256 aes128-CBC with 600,001 iterations
Expand Down