IL cleanup - remove .module and make .assembly match source name #62812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @hoyosjs Issue Details/cc @dotnet/jit-contrib
|
Member
Author
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BruceForstall
approved these changes
Dec 15, 2021
Contributor
|
Question: all these cleanups are nice. Will newly written tests be required to follow all the cleanup "rules"? |
Member
Author
|
@BruceForstall - we'll definitely need to add documentation describing the new testing model in more detail. Once all tests have been converted to the new merged wrapper model, authoring a new ILPROJ test will require applying the three transformations (removing .module, making sure .assembly matches the file and adding the [Fact] attribute on main), otherwise the test simply won't work (the Roslyn source generator cannot locate its entrypoint). |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @dotnet/jit-contrib