Skip to content

Fixing a crash bug #63222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 30, 2021
Merged

Fixing a crash bug #63222

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fe7881
Fixing a crash bug
masonwheeler Dec 30, 2021
cc87813
Updating PR in response to review feedback.
masonwheeler Dec 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/coreclr/tools/ILVerification/ILVerifyTypeSystemContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,11 @@ internal override ModuleDesc ResolveModule(IAssemblyDesc referencingModule, stri
private EcmaModule ResolveAssemblyOrNetmodule(string simpleName, string verificationName, IAssemblyDesc containingAssembly, bool throwIfNotFound)
{
PEReader peReader = _resolver.Resolve(simpleName);
if (peReader == null && throwIfNotFound)
if (peReader == null)
{
throw new VerifierException("Assembly or module not found: " + simpleName);
if (throwIfNotFound)
throw new VerifierException("Assembly or module not found: " + simpleName);
return null;
}
var module = GetModule(peReader, containingAssembly);
VerifyModuleName(verificationName, module);
Expand Down