Improve SuperPMI error message for JIT asserts #63229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the method context numbers are output for each failure, but the assert message is output separately, so if there are multiple asserts that fire, and you want to investigate a particular one, it's hard to figure out which method context number to use. Add the method context number to the assert message, so the relationship between the method context number and the assert is obvious. E.g., you always get messages like the following (both before this change and after): ``` ERROR: Exception thrown: DebugBreak or AV Exception 123 ERROR: main method 16501 of size 286 failed to load and compile correctly. ``` Before you might see an assert like: ``` ISSUE: <ASSERT> C:\gh\runtime6\src\coreclr\jit\fgbasic.cpp (4699) - Assertion failed '!"unexpected case 1"' in 'CancellationTokenSource:ExecuteCallbackHandlers(bool):this' during 'Update flow graph opt pass' (IL size 286) ``` Now, it will look like: ``` ISSUE: <ASSERT> dotnet#16501 C:\gh\runtime6\src\coreclr\jit\fgbasic.cpp (4699) - Assertion failed '!"unexpected case 1"' in 'CancellationTokenSource:ExecuteCallbackHandlers(bool):this' during 'Update flow graph opt pass' (IL size 286) ```
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsCurrently, the method context numbers are output for each failure, Add the method context number to the assert message, so the relationship E.g., you always get messages like the following (both before this change Before you might see an assert like: Now, it will look like:
|
Contributor
Author
|
@dotnet/jit-contrib PTAL |
echesakov
approved these changes
Dec 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the method context numbers are output for each failure,
but the assert message is output separately, so if there are multiple
asserts that fire, and you want to investigate a particular one,
it's hard to figure out which method context number to use.
Add the method context number to the assert message, so the relationship
between the method context number and the assert is obvious.
E.g., you always get messages like the following (both before this change
and after):
Before you might see an assert like:
Now, it will look like: