Skip to content

Fix GetSpanDataFrom #63306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 4, 2022
Merged

Fix GetSpanDataFrom #63306

merged 3 commits into from
Jan 4, 2022

Conversation

@davidwrighton
Copy link
Member

@davidwrighton davidwrighton commented Jan 3, 2022

  • GC Protect the type parameter
  • set data to value before asserting that it isn't NULL

Fixes #62285

@davidwrighton
Fix GetSpanDataFrom implementation
806c946 
- GC Protect the type parameter
- set data to value before asserting that it isn't NULL
@davidwrighton
Re-enable test
ec2632f
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 3, 2022
@ghost ghost assigned davidwrighton Jan 3, 2022
@ghost
Copy link

ghost commented Jan 3, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details
  • GC Protect the type parameter
  • set data to value before asserting that it isn't NULL

Fixes #62285

Author: davidwrighton
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes Jan 3, 2022
View reviewed changes
@davidwrighton davidwrighton merged commit 56ffec2 into dotnet:main Jan 4, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2022
@davidwrighton davidwrighton deleted the fix_get_span_data_From branch April 13, 2023 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees

@davidwrighton davidwrighton

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

jit/intrinsics/createspan_il/createspan_il.sh

3 participants

@davidwrighton @AaronRobinsonMSFT @jkotas