-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Group 2] Enable nullable annotations for Microsoft.Extensions.Options
#63767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-extensions-options Issue DetailsRelated to #43605 Questions:
Other questions:
|
src/libraries/Microsoft.Extensions.Options/ref/Microsoft.Extensions.Options.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Options/ref/Microsoft.Extensions.Options.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Options/ref/Microsoft.Extensions.Options.cs
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Options/ref/Microsoft.Extensions.Options.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Options/ref/Microsoft.Extensions.Options.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Options/ref/Microsoft.Extensions.Options.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Options/src/OptionsFactory.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Options/src/OptionsServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Options/src/ValidateOptions.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Options/src/ValidateOptionsResult.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Options/src/OptionsValidationException.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Options/ref/Microsoft.Extensions.Options.cs
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Options/src/ValidateOptions.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Options/src/OptionsFactory.cs
Outdated
Show resolved
Hide resolved
eerhardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for all your hard work here @maxkoshevoi!
LGTM
Related to #43605
Questions:
failureMessageshould be nullable, but there's never a null-check for itOptionsFactory.Createnameparameter looks like it should be nullable, butOptionsValidationExceptionwill throw ifnameisnullOther questions:
dotnet msbuild /t:GenerateReferenceAssemblySourcedoesn't update nullable annotations. How can I updatereffiles automatically? (there were a lot of?s in this PR)