Console.Unix: fix missing terminal configuration on SIGINT/SIGQUIT/SGCONT. #64200
Conversation
…GCONT. The introduction of the managed API for signal handling (PosixSignal) inadvertently caused terminal configuration to no longer be performed when no managed handlers are registered. This adds back the unconditional registration for SIGINT/SIGQUIT/SIGCONT. The missing registrations can cause the terminal to stop echoing when an application terminates on Ctrl-C.
ghost
added
area-System.Net
community-contribution
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThe introduction of the managed API for signal handling (PosixSignal) This adds back the unconditional registration for SIGINT/SIGQUIT/SIGCONT. The missing registrations can cause the terminal to stop echoing when an Regressed in #54136. cc @stephentoub @adamsitnik @danielbisar
|
|
Tagging subscribers to this area: @dotnet/area-system-console Issue DetailsThe introduction of the managed API for signal handling (PosixSignal) This adds back the unconditional registration for SIGINT/SIGQUIT/SIGCONT. The missing registrations can cause the terminal to stop echoing when an Regressed in #54136. cc @stephentoub @adamsitnik @danielbisar
|
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
Thanks. Is there any reasonable way to add a test for this?
I thought about it, and it's not easy to write an automated test for this. A good test would have something other than .NET as a parent because .NET changes terminal settings also as child processes are created/reaped. |
|
@stephentoub @adamsitnik is this good to be merged? After it sat on |
|
Thanks, Tom. |
|
@tmds thanks for the fix! I am going to start the backport procedure now, as I expect that it will take us few weeks to get it merged /backport to release/6.0 |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1812920689 |
ghost
locked as resolved and limited conversation to collaborators
|
I closed the backport PR as stale. cc @dotnet/area-system-console since @tmds is requesting we backport this. One of them would have to champion it, add the template, etc. |
4 participants
The introduction of the managed API for signal handling (PosixSignal)
inadvertently caused terminal configuration to no longer be performed
when no managed handlers are registered.
This adds back the unconditional registration for SIGINT/SIGQUIT/SIGCONT.
The missing registrations can cause the terminal to stop echoing when an
application terminates on Ctrl-C.
Regressed in #54136.
Fixes #64166.
cc @stephentoub @adamsitnik @danielbisar