Skip to content

Conversation

@ViktorHofer
Copy link
Member

Some libraries still had ProjectReferences to libraries which refs
were added to the targeting pack with the last release. Therefore these
references can just be normal "Reference" items instead of P2Ps.

@ghost
Copy link

ghost commented Jan 30, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Some libraries still had ProjectReferences to libraries which refs
were added to the targeting pack with the last release. Therefore these
references can just be normal "Reference" items instead of P2Ps.

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries

Milestone: -

Some libraries still had ProjectReferences to libraries which refs
were added to the targeting pack with the last release. Therefore these
references can just be normal "Reference" items instead of P2Ps.
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if we can catch this with a validation target so that folks don't introduce more?

@ViktorHofer ViktorHofer merged commit 4a19a49 into dotnet:main Jan 31, 2022
@ViktorHofer ViktorHofer deleted the UseReferencesInsteadOfP2Ps branch January 31, 2022 20:16
@ViktorHofer
Copy link
Member Author

LGTM. I wonder if we can catch this with a validation target so that folks don't introduce more?

Such validation (either via a target or even without one) could be easily implemented. Ideally we would go the opposite way and use P2Ps everywhere which is why I'm a bit torn.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants