[mono] Add an 'allow-loader-errors' AOT option. #64640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vargaz
requested review from
SamMonoRT,
imhameed and
lambdageek
as code owners
ghost
added
the
lambdageek
reviewed
Feb 1, 2022
Member
lambdageek
left a comment
lambdageek
left a comment
There was a problem hiding this comment.
it's not just loader errors.
There could be marshaler errors, too, for example:
runtime/src/mono/mono/mini/aot-compiler.c
Lines 5173 to 5174 in 53d5288
And there are other calls to mono_error_assert_ok in aot-compiler.c that could be masking loader errors.
lambdageek
approved these changes
Feb 1, 2022
This can be used to avoid aborting the AOT process if a loader error occurs. The methods which fail to load will not be AOTed and the failures will happen at runtime. Related: dotnet#63654
vargaz
force-pushed
the
allow-loader-errors
branch
from
b1a2945 to
bb823aa
Compare
Contributor
Author
|
Renamed the option to 'allow-errors'. If the tests hit one of those assertions, we can convert them to errors as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used to avoid aborting the AOT process if a loader
error occurs. The methods which fail to load will not be AOTed and
the failures will happen at runtime.
Related:
#63654