[release/6.0] vtable setup fix for generic default interface methods in mono runtime #64754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When processing the overrides from interface default methods we should check if the interface class is a generic type definition first and inflate with the interface class context. Test case included.
github-actions
bot
requested review from
lambdageek,
thaystg and
vargaz
as code owners
ghost
added
the
…64102-to-release/6.0
rbhanda
added
Servicing-approved
thaystg
approved these changes
Feb 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #64102 to release/6.0
/cc @lambdageek @bholmes
Related to #61244
Customer Impact
Customer code that has default interface methods on generic interfaces that implements a method from a base interface that has a different number or different order of generic parameters may crash or setup the method vtable incorrectly. This affects customer code on Blazor WebAssembly and .NET for mobile (iOS and Android).
Testing
manual testing and new CI tests.
Risk
Moderate. The code change affects the initialization for default interface methods in generic interfaces even in cases that previously worked correctly. It is possible that despite our existing tests we may introduce a regression into some existing code that works correctly today.