Skip to content

Conversation

@jkoritzinsky
Copy link
Member

Update the Roslyn Testing SDK version and update the DllImportGenerator unit tests to crash in a way that produces a dump for some of our intermittent issues (#60909, #62223). This mechanism will crash the process during the "exception filter" phase, so it will still have the throwing frame on the stack (no unwinding). Hopefully this will enable us to get more actionable dumps to investigate these issues and determine if they're Roslyn bugs or GC holes.

cc: @dotnet/interop-contrib
cc: @agocke

…e actionable.

Update the Roslyn Testing SDK version and update the DllImportGenerator unit tests to crash in a way that produces a dump for some of our intermittent issues (dotnet#60909, dotnet#62223). This mechanism will crash the process during the "exception filter" phase, so it will still have the throwing frame on the stack (no unwinding). Hopefully this will enable us to get more actionable dumps to investigate these issues and determine if they're Roslyn bugs or GC holes.
@ghost
Copy link

ghost commented Feb 4, 2022

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Update the Roslyn Testing SDK version and update the DllImportGenerator unit tests to crash in a way that produces a dump for some of our intermittent issues (#60909, #62223). This mechanism will crash the process during the "exception filter" phase, so it will still have the throwing frame on the stack (no unwinding). Hopefully this will enable us to get more actionable dumps to investigate these issues and determine if they're Roslyn bugs or GC holes.

cc: @dotnet/interop-contrib
cc: @agocke

Author: jkoritzinsky
Assignees: -
Labels:

area-System.Runtime.InteropServices

Milestone: -

@jkoritzinsky
Copy link
Member Author

Mac timeouts are unrelated. Merging in.

@jkoritzinsky jkoritzinsky merged commit dbd4cbb into dotnet:main Feb 5, 2022
@jkoritzinsky jkoritzinsky deleted the crash-on-exception-dllimportgen-unit-tests branch February 5, 2022 17:58
analyzerExceptionFilter: ex =>
{
// We're hunting down a intermittent issue that causes NullReferenceExceptions deep in Roslyn. To ensure that we get an actionable dump, we're going to FailFast here to force a process dump.
if (ex is NullReferenceException)
Copy link
Member

@agocke agocke Feb 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider always crashing, except for maybe OperationCancelledException, if you produce that. Maybe you'll find some interesting crashes

@ghost ghost locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants