Skip to content

Record callee saves in patchpoint info #65196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2022
Merged

Record callee saves in patchpoint info #65196

merged 1 commit into from
Feb 11, 2022

Conversation

@AndyAyersMS
Copy link
Member

@AndyAyersMS AndyAyersMS commented Feb 11, 2022

Preparatory work for fixing the x64 epilog unwind problem for OSR methods.
Changes the jit guid since the PatchpointInfo data structure is altered.

@AndyAyersMS
Record callee saves in patchpoint info
66ea70b 
Preparatory work for fixing the x64 epilog unwind problem for OSR methods.
Changes the jit guid since the PatchpointInfo data structure is altered.
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 11, 2022
@ghost ghost assigned AndyAyersMS Feb 11, 2022
@ghost
Copy link

ghost commented Feb 11, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Preparatory work for fixing the x64 epilog unwind problem for OSR methods.
Changes the jit guid since the PatchpointInfo data structure is altered.

Author: AndyAyersMS
Assignees: AndyAyersMS
Labels:

area-CodeGen-coreclr
Milestone: -

@AndyAyersMS
Copy link
Member Author

AndyAyersMS commented Feb 11, 2022

@BruceForstall PTAL
cc @dotnet/jit-contrib

Changing the jit guid not strictly required as this data structure is produced and consumed in process. But the update will invalidate SPMI images that might have captured old patchpoint info. Without this the jit would likely blow up on these old OSR method contexts.

I'm pushing just this small change to let me collect new SPMI with this info, so I can have a base of OSR methods to work with for the next stage of these changes.

This was referenced Feb 11, 2022
Closed
Open
@AndyAyersMS
Copy link
Member Author

AndyAyersMS commented Feb 11, 2022 •
edited
Loading

Nothing here is enabled by default, so failures are unrelated. Retrying.

@AndyAyersMS AndyAyersMS merged commit 0b61a12 into dotnet:main Feb 11, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@BruceForstall BruceForstall BruceForstall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@AndyAyersMS AndyAyersMS

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndyAyersMS @BruceForstall