[release/6.0] [mono][s390x] Fix OP_FCONV_TO_I and OP_RCONV_TO_I #65328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* OP_[FR]CONV_TO_I should result in an 8-byte integer
github-actions
bot
requested review from
SamMonoRT,
imhameed,
lambdageek and
vargaz
as code owners
ghost
added
the
Member
|
The x64 and arm64 fix for the same issue is #65329 |
Contributor
|
Note that this fixes a regression, at least as far as CI status is concerned: when #64556 was merged into 6.0 recently, some of the new test cases added as part of that PR now fail on s390x, making the CI status red. This PR should get us back to green again. (Of course, the bug was pre-existing and only exposed by the new test, but it is worth fixing anyway.) |
vargaz
approved these changes
Feb 18, 2022
fuad775
approved these changes
Feb 21, 2022
rbhanda
added
Servicing-approved
Member
|
the wasm aot failure is #66366 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #65185 to release/6.0
/cc @lambdageek @uweigand
Customer Impact
Conversions from a float to a native integer type incorrectly treat the result as a 32-bit quantity on 64-bit platforms. This PR is for the S390x platform only, the x64 and arm64 fix is in #65329
Testing
CI
Risk
Low.