Update tests to help uncover CrossGen2 scenario validation #65477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support in Mono for the ByReference`1 being considered a ref field during Explicit offset validation.
AaronRobinsonMSFT
requested review from
lambdageek,
thaystg and
vargaz
as code owners
ghost
added
the
vargaz
approved these changes
Feb 17, 2022
MichalStrehovsky
approved these changes
Feb 17, 2022
Member
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
There was a problem hiding this comment.
Looks good otherwise!
src/coreclr/tools/Common/TypeSystem/Common/ExplicitLayoutValidator.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support in Mono for the ByReference`1 being considered a ref field during Explicit offset validation.
/cc @MichalStrehovsky @lambdageek