[release/6.0] Backport Fix PerformanceCounter's when running with Globalization Invariant Mode

[tarekgh]

Fixes #65502

Backport of #65414 to release/6.0

/cc @tarekgh

Customer Impact

This is a migration to .NET 6.0 blocker for users who enable Globalization Invariant Mode on their app and try to use the performance counter library.
Performance counter library has old code which creating CultureInfo object using LCID. LCID is an obsolete concept, and it is recommended to always create a culture with the language tag names instead. When enabling the Globalization Invariant Mode, we don't support creating cultures using LCID at all as we don't depend on the underlying OS at all. This will cause the code in the performance counter library to throw an exception. That means there is no way to use this library when enabling the invariant mode.

Testing

This change is already merged in .NET 7.0 and passing all regression and CI tests. Also, I added a new test for testing the library when enabling the Globalization Invariant Mode.

Risk

Low as the change scoped to the performance counter library which is supported on Windows only and all the changes is changing the creation of the culture using the LCID to use the culture name instead which should be exact result anyway but will avoid the exception.

[ghost]

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti, @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

---

null

Author:	tarekgh
Assignees:	tarekgh
Labels:	area-System.Diagnostics.Tracing
Milestone:	-

[ghost]

Tagging subscribers to this area: @dotnet/area-system-diagnostics-performancecounter
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Backport of #65414 to release/6.0

/cc @tarekgh

Customer Impact

This is a migration to .NET 6.0 blocker for users who enable Globalization Invariant Mode on their app and try to use the performance counter library.
Performance counter library has old code which creating CultureInfo object using LCID. LCID is an obsolete concept, and it is recommended to always create a culture with the language tag names instead. When enabling the Globalization Invariant Mode, we don't support creating cultures using LCID at all as we don't depend on the underlying OS at all. This will cause the code in the performance counter library to throw an exception. That means there is no way to use this library when enabling the invariant mode.

Testing

This change is already merged in .NET 7.0 and passing all regression and CI tests. Also, I added a new test for testing the library when enabling the Globalization Invariant Mode.

Risk

The low as the change scoped to the performance counter library which is supported on Windows only and all the changes is changing the creation of the culture using the LCID to use the culture name instead which should be exact result anyway but will avoid the exception.

Author:	tarekgh
Assignees:	tarekgh
Labels:	area-System.Diagnostics.PerformanceCounter
Milestone:	-

[carlossanlop]

@tarekgh just noticed this change affects an OOB package. Per the servicing instructions, if the csproj has the <IsPackable>true</IsPackable> property (which it does), then you also need to set the <GeneratePackageOnBuild>true</GeneratePackageOnBuild> property.

You also need to add the <ServicingVersion>1</ServicingVersion> property, since it's the first time this package gets serviced. (If it had already existed, you would just have to bump the version number to the next integer).

Here are a couple of examples (we had to add the property on the next release because we forgot): #65523 #65733

Can you please add the change?

[tarekgh]

@carlossanlop @ericstj could you please have a look at the last commit in this PR? Thanks!

[ericstj]

LGTM

[ericstj]

Failure is fixed by #66366