Skip to content

Annotating Native CoreLib library to be AOT friendly #66112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 7, 2022
Merged

Annotating Native CoreLib library to be AOT friendly #66112

merged 4 commits into from
Mar 7, 2022

Conversation

@LakshanF
Copy link
Contributor

@LakshanF LakshanF commented Mar 2, 2022

Propagated RequiresDynamicCode attribute that are tagged on API's that are dangerous for Native AOT within CoreLib to make the library to be AOT friendly.

Required adding the annotation to the public surface area which in turn required the reference APIs to be annotated (and the CoreCLR and Mono library implementation to be annotated)

@ghost ghost assigned LakshanF Mar 2, 2022
@ghost
Copy link

ghost commented Mar 2, 2022

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Mar 2, 2022

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Propagated RequiresDynamicCode attribute that are tagged on API's that are dangerous for Native AOT within CoreLib to make the library to be AOT friendly.

Required adding the annotation to the public surface area which in turn required the reference APIs to be annotated (and the CoreCLR and Mono library implementation to be annotated)

Author: LakshanF
Assignees: LakshanF
Labels:

area-System.Reflection, new-api-needs-documentation
Milestone: -

@LakshanF LakshanF requested a review from eerhardt March 2, 2022 21:57
jkotas
jkotas reviewed Mar 3, 2022
View reviewed changes
This was referenced Mar 3, 2022
Closed
Closed
Closed
@LakshanF @jkotas
Update src/libraries/System.Private.CoreLib/src/Internal/Runtime/Inte…
789848b 
…ropServices/ComponentActivator.cs

Co-authored-by: Jan Kotas <[email protected]>
MichalStrehovsky
MichalStrehovsky approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@LakshanF LakshanF merged commit 14c3a15 into dotnet:main Mar 7, 2022
@LakshanF LakshanF deleted the AOT_Lib_Annotation branch March 7, 2022 17:02
@ghost ghost locked as resolved and limited conversation to collaborators Apr 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotas jkotas jkotas left review comments

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@eerhardt eerhardt Awaiting requested review from eerhardt

Assignees

@LakshanF LakshanF

Labels

area-System.Reflection new-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LakshanF @jkotas @MichalStrehovsky