Fix issues related to JsonSerializerOptions mutation and caching. #66248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tnet#65863) * Fix issues related to JsonSerializerOptions mutation and caching. * fix test style * fix linker warning
|
Tagging subscribers to this area: @dotnet/area-system-text-json |
This was referenced Mar 5, 2022
|
CI failures are related to #65791, STJ tests are now passing in all jobs. |
jkotas
approved these changes
Mar 7, 2022
|
Improvements on alpine-x64 dotnet/perf-autofiling-issues#3981 |
|
@EgorBo unlikely that the perf improvements are related to this change, benchmark in question is for DataContractJsonSerializer. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt at merging #65863. Original PR introduced test failures in netfx and was reverted in #66235.
cc @jkotas