Fix up DiagnosticName of RuntimeDetermined types #66937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Name/Namespace of these already includes the details type name. Bring this over to DiagnosticName too. This is so that we can distinguish between `List<__Canon>` and List<T___Canon>`.
This was referenced Mar 21, 2022
jkotas
approved these changes
Mar 21, 2022
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
Name/Namespace of these already includes the details type name. Bring this over to DiagnosticName too. This is so that we can distinguish between `List<__Canon>` and List<T___Canon>`.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name/Namespace of these already includes the details type name. Bring this over to DiagnosticName too.
This is so that we can distinguish between
List<__Canon>and List<T___Canon>`.