Make ReRegisterForFinalize GC test more robust #67896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no guarantee that the JIT does not introduce a temporary for the read of the fields `obj1` and `obj2` when they are passed to the function calls, which might keep them alive even when nulling out the fields. This happens when CFG is enabled, causing the test to fail. Change the test to access the fields in separate methods marked as noinline to fix the problem.
ghost
assigned
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsThere is no guarantee that the JIT does not introduce a temporary for Change the test to access the fields in separate methods marked as
|
Maoni0
approved these changes
Apr 12, 2022
Member
Maoni0
left a comment
Maoni0
left a comment
There was a problem hiding this comment.
LGTM. thanks for making this fix!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no guarantee that the JIT does not introduce a temporary for
the read of the fields
obj1andobj2when they are passed to thefunction calls, which might keep them alive even when nulling out the
fields. This happens when CFG is enabled, causing the test to fail.
Change the test to access the fields in separate methods marked as
noinline to fix the problem.