Skip to content

Ensure TestHandleCollector has enough memory pressure to trigger #68652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2022
Merged

Ensure TestHandleCollector has enough memory pressure to trigger #68652

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73b6a4d
Ensure TestHandleCollector has enough memory pressure to trigger
AaronRobinsonMSFT Apr 28, 2022
0628dac
Address out of memory issues with large int[] allocation.
AaronRobinsonMSFT Apr 28, 2022
1c8cd77
Apply suggestions from code review
AaronRobinsonMSFT Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ....Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/HandleCollectorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace System.Runtime.InteropServices
public class HandleCollectorTests
{
private const int LowLimitSize = 20;
private const int HighLimitSize = 100000;
private const int HighLimitSize = 100_000;

[Theory]
[InlineData(null, 0)]
Expand Down Expand Up @@ -128,6 +128,7 @@ public static void TestHandleCollector()
for (int i = 0; i < LowLimitSize + 1; ++i)
{
HandleLimitTester hlt = new HandleLimitTester(lowLimitCollector);
Assert.True(lowLimitCollector.Count <= i + 1);
}

// HandleLimitTester does the decrement on the HandleCollector during finalization, so we wait for pending finalizers.
Expand All @@ -142,6 +143,7 @@ public static void TestHandleCollector()
for (int i = 0; i < HighLimitSize + 10; ++i)
{
HandleLimitTester hlt = new HandleLimitTester(highLimitCollector);
Assert.True(highLimitCollector.Count <= i + 1);
}

// HandleLimitTester does the decrement on the HandleCollector during finalization, so we wait for pending finalizers.
Expand All @@ -155,11 +157,15 @@ public static void TestHandleCollector()

private sealed class HandleLimitTester
{
private HandleCollector _collector;
private readonly HandleCollector _collector;
private readonly int[] _pressure;

internal HandleLimitTester(HandleCollector collector)
{
_collector = collector;
// Adding an allocation to ensure memory pressure exists so the call to
// GC.Collect() in the Add() method below will have something to do.
_pressure = new int[1_000];
_collector.Add();
GC.KeepAlive(this);
}
Expand Down