Switch extra platform coverage from windowsservercore-2004 to windowsservercore-ltsc2019 #69480
Conversation
…dowsservercore-ltsc2019 This should be the oldest server OS that we still support apart from 20H2 which is EOL in a couple of months.
ghost
assigned
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsIf I understand correctly this should be the oldest server OS that we still support
|
|
/azp run runtime-extra-platforms, runtime-libraries-coreclr outerloop-windows |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jakobbotsch
changed the title
|
@dotnet/area-system-io A couple of System.IO.Ports tests are failing on the Windows Server 2019 OS added in this PR (see the These tests are already disabled on Nano Server, but it looks to me that the tests should be expected to succeed. COM1 is not present in PortHelper.GetPorts result
PortHelper Ports:
SerialPort Ports: COM1,COM2
Expected: True
Actual: False
System.IO.FileNotFoundException : Could not find file 'COM1'.This implies to me that I will disable the tests on Windows Server Core as well to unblock this, but not sure if it's the right long term solution. |
|
/azp run runtime-extra-platforms, runtime-libraries-coreclr outerloop-windows |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
ping @dotnet/area-system-io for @jakobbotsch question above. cc @danmoseley as you experimented in the past with windows server core |
|
@leecow @richlander @danmoseley @agocke Can you help provide guidance on what Server Core OS we should be testing here? Previously we were testing Server Core 2004 which according to this page has been EOL since December last year. This PR is updating the coverage to Server Core LTSC2019 that is supported until 2024. |
@jakobbotsch was the failure consistent? it may be flakyness in the Ports test, did you hit retry? in any case, the best is to file an issue to address the error. |
| /// </summary> | ||
| [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer))] | ||
| [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoNorServerCore))] | ||
| [ActiveIssue("https://github.com/dotnet/runtime/issues/34490", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)] |
There was a problem hiding this comment.
This issue is closed.
| [ActiveIssue("https://github.com/dotnet/runtime/issues/34490", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)] |
There was a problem hiding this comment.
I think you should submit a separate PR to see if this can be reenabled on Mono. This PR is not about System.IO.Ports so I would rather not change this and end up with two more rounds of CI in case this is still blocked on something.
@jakobbotsch was the failure consistent? it may be flakyness in the Ports test, did you hit retry? in any case, the best is to file an issue to address the error.
I did not retry. I doubt this is just flakyness given the two separate failing tests and their log output (File.Open failed for COM1 and PortHelper.GetPorts seems to correctly report the available ports, while SerialPort.PortNames does not).
|
Looks like you are on the right path. FYI: LTSC 2019 is the primary OS for Windows containers in AKS. |
|
I'll give a bit more time for feedback and otherwise merge this at the end of the day. |
5 participants
As discussed in #67728, move this to a newer OS. windowsservercore-2004 has been EOL since Dec 2021.
If I understand correctly windowsservercore-ltsc2019 should be the oldest server OS that we still support
apart from 20H2 which is EOL in a couple of months, so I suggest we skip that one.
Fixes #67728