Introduce System.Runtime.TieredPGO knob #71438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Member
Author
|
Not sure who to ask for review, @AndyAyersMS ? |
AndyAyersMS
reviewed
Jun 30, 2022
Member
AndyAyersMS
left a comment
AndyAyersMS
left a comment
There was a problem hiding this comment.
Looks good to me, but maybe somebody on the runtime side should sign off?
cc @mangod9
stephentoub
approved these changes
Jul 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related SDK PR: dotnet/sdk#26350
The idea is to introduce a configuration switch similar to
TieredCompilationto expose a config switch forTieredPGO. It's done because many of our first/third parties are interested in trying Dynamic PGO and currently it's only possible withDOTNET_TieredPGO=1env. variable defined in the execution process.With this PR and the related SDK change customers will be able to turn it on (it's off by default) via MSBUILD or JSON config just like TieredCompilation, e.g.: