Skip to content

Conversation

@mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Jul 8, 2022

Follow up to #71657.

Update the Trace Event Version to 3.0.3 to include Mono as a known RuntimeSku for generating .nettrace and .mibc on Mono. Without it, the runtime value in the Rundown Runtime/Start event and ultimately the runtime value in a MibcConfig for a mono based .mibc will be 4 instead of Mono.

@mdh1418 mdh1418 added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jul 8, 2022
@ghost
Copy link

ghost commented Jul 8, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@mdh1418 mdh1418 removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 6, 2022
@mdh1418 mdh1418 marked this pull request as ready for review August 6, 2022 02:16
@mdh1418 mdh1418 requested a review from tommcdon August 6, 2022 02:16
@mdh1418
Copy link
Member Author

mdh1418 commented Aug 6, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mdh1418
Copy link
Member Author

mdh1418 commented Aug 10, 2022

The failure on runtime is known and tracked in the referenced issue.
The failures on runtime-extra-platforms are unrelated

@mdh1418 mdh1418 merged commit 23905fe into dotnet:main Aug 10, 2022
@mdh1418 mdh1418 deleted the rev_traceeventversion_3.0.3 branch August 10, 2022 16:49
@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants