Skip to content

[wasm] Fix failing CI test, and misc fixes #72293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 18, 2022
Merged

[wasm] Fix failing CI test, and misc fixes #72293

merged 4 commits into from
Jul 18, 2022

Conversation

@radical
Copy link
Member

@radical radical commented Jul 15, 2022 •
edited
Loading

WasmAppHost:

  • use a custom console logger to remove logger prefixes from output
  • Find the js engine to run, so a useful, and clean error can be emitted
  • Ensure that all process output handlers have run, before exiting

MSBuild tasks:

  • Emit exit code from MonoAOTCompiler, and EmccCompile tasks when the process fails. Useful when looking at logs.

Fixes #71887 .

@radical radical added arch-wasm WebAssembly architecture area-Build-mono labels Jul 15, 2022
@ghost
Copy link

ghost commented Jul 15, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono
Milestone: -

@ghost ghost assigned radical Jul 15, 2022
@radical radical changed the title [wasm] Misc test, and host fixes [wasm] WasmAppHost, and task fixes Jul 16, 2022
@radical radical requested a review from radekdoulik July 16, 2022 04:20
@radical radical marked this pull request as ready for review July 16, 2022 04:20
@radical radical changed the title [wasm] WasmAppHost, and task fixes [wasm] Fix failing CI test, and misc fixes Jul 16, 2022
@lewing lewing merged commit b959fbc into dotnet:main Jul 18, 2022
@radical radical deleted the misc-fixes branch July 18, 2022 18:15
@ghost ghost locked as resolved and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewing lewing lewing approved these changes

@radekdoulik radekdoulik Awaiting requested review from radekdoulik

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

Assignees

@radical radical

Labels

arch-wasm WebAssembly architecture area-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[wasm] WasmTemplateTests for console failing due to truncated output

2 participants

@radical @lewing