[mono][aot] Fix the adding of generic instances referenced by gshared… #72377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Contributor
Author
|
/azp run runtime-wasm |
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
ivanpovazan
approved these changes
Jul 18, 2022
Member
ivanpovazan
left a comment
ivanpovazan
left a comment
There was a problem hiding this comment.
Tested by intentionally skipping the generation of GSHAREDVT variant for a particular generic method and running it from an inflated caller.
lgtm
Member
|
looks like #72386 is blocking the wasm build |
… methods. These methods store their data in a MONO_PATCH_INFO_GSHARED_METHOD_INFO which was not handled properly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… methods.
These methods store their data in a MONO_PATCH_INFO_GSHARED_METHOD_INFO which was not handled properly.