PlatformNotSupportedException for UNIX domain sockets on iOS/tvOS #73374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
directhex
force-pushed
the
PNSE-domain-sockets-on-ios-tvos
branch
from
b0418b0 to
d17c748
Compare
jkotas
reviewed
Aug 4, 2022
src/libraries/Common/src/System/Net/SocketProtocolSupportPal.cs
Outdated
Show resolved
Hide resolved
directhex
force-pushed
the
PNSE-domain-sockets-on-ios-tvos
branch
from
49fcad8 to
2f7ff83
Compare
The same ones which fail on Linux Bionic, which has a similar problem
src/libraries/Common/src/System/Net/SocketProtocolSupportPal.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Theodore Tsirpanis <[email protected]>
akoeplinger
approved these changes
Aug 8, 2022
Member
akoeplinger
left a comment
akoeplinger
left a comment
There was a problem hiding this comment.
looks good, just a few comments
src/libraries/Common/src/System/Net/SocketProtocolSupportPal.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/StreamConformanceTests/System/IO/StreamConformanceTests.cs
Show resolved
Hide resolved
src/libraries/System.Net.Sockets/src/System/Net/Sockets/UnixDomainSocketEndPoint.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Sockets/tests/FunctionalTests/UnixDomainSocketTest.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
akoeplinger
approved these changes
Aug 9, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly mark UNIX domain sockets (and named pipes) with PlatformNotSupportedException.
These never worked on device, where the kernel returns EPERM on socket bind. They worked on the simulator when using
/tmpas the temporary directory instead of the value fromNSTemporaryDirectory(), but this seems to be an oversight by Apple rather than by design - and /tmp is not writable on device. In cases where device and simulator differ, we need to present the device scenario to our users as the canonically correct one.See discussion in #73258
Closes: #51390
Closes: #51335