[wasm] crypto deadlock fix #73537
Merged
[wasm] crypto deadlock fix #73537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
radical
reviewed
Aug 8, 2022
radical
reviewed
Aug 8, 2022
Co-authored-by: Ankit Jain <[email protected]>
Co-authored-by: Ankit Jain <[email protected]>
Member
Author
|
CI test with multiple workitems on Helix is #73629 |
10 tasks
maraf
approved these changes
Aug 9, 2022
eerhardt
approved these changes
Aug 9, 2022
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
Overall this looks good to me. Thanks for fixing this!
I just had a few nit-ish comments.
Member
|
re:having-spin-or-nonblocking-in-fn-name, I added those to make it obvious to spot cases where they might get used in incorrect contexts. For example, using a spin wait for a state inside a lock, which could cause a deadlock because the other side is waiting for that lock, so it can change the state. |
renamed the subtle-crypto.ts file, because that's not a worker
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crypto deadlock: Log on main